Re: [PATCH] Wait for console to become available, v2

From: David VomLehn
Date: Sun Apr 19 2009 - 19:27:12 EST


Andi Kleen wrote:
On Sun, Apr 19, 2009 at 09:23:36AM -0700, David VomLehn wrote:
Andi Kleen wrote:
VomLehn <dvomlehn@xxxxxxxxx> writes:
...
Also a setting to panic in this case might be useful, normally a system
without console is not very useful and needs to be rebooted anyways.
Umm, those of us in the embedded space have the, perhaps misguided, notion that our systems are quite useful without consoles...

That seems more like a special case that shouldn't be default?

I have to disagree. Panicing because you can't open /dev/console is likely to mean that you get no output at all and so no chance to see a message explaining why the open failed. If the open failure is all that happened, the rest of the system may very well come up normally. You would then be able to look at the kernel log and diagnose the issue.

In any case, the purpose of this patch is fix USB consoles to work as they did before parallelized startup. This involves addressing a race condition that, theoretically, always existed but which previously hadn't been a problem. Changing the behavior when init_post() can't open /dev/console seems out of scope.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/