Re: [RESEND][PATCH -tip 1/3] x86, mce: Revert "add mce_threshold option for intel cmci"

From: Andi Kleen
Date: Mon Apr 20 2009 - 03:21:19 EST


Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> writes:

> After having some discussion with Andi Kleen, we have concluded
> that setting threshold >1 will not work properly. This patch
> reverts the previous patch that introduces mce_threshold option.
>
> However as Ingo pointed out, cmci is a new feature so having boot
> controls to disable it is generally a good idea, and it might be
> handy if the hw is misbehaving.
>
> So instead of mce_threshold, I will introduce "mce=no_cmci" option
> to support cmci disablement in later patch.
> Compare with mce_threshold, it lacks threshold >1 support but it
> does not matter because it will not work.
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>
> Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/