Re: [PATCH] PM/Suspend: Introduce two new platform callbacks toavoid breakage (Re: 900af0d breaks some embedded suspend/resume)

[Nigel Cunningham]

Hi.

On Mon, 2009-04-20 at 09:35 +0100, Russell King wrote:
> On Mon, Apr 20, 2009 at 09:31:47AM +1000, Nigel Cunningham wrote:
> > >  	}
> > >  
> > > -	if (suspend_ops->prepare) {
> > > -		error = suspend_ops->prepare();
> > > +	if (suspend_ops->prepare_late) {
> > > +		error = suspend_ops->prepare_late();
> > >  		if (error)
> > >  			goto Power_up_devices;
> > >  	}
> > 
> > Doesn't this invalidate testing that's already been done? Drivers
> > implementing prepare() (arm omap1, pxa, omap2, s3c and powerpc mpc52xx
> > and lite5200) are now going to have it called pre device_power_down.
> 
> ... which is the way it has always been done prior to the change which
> broke stuff.  So this patch is putting the ordering back the way it was
> which has been well proven to work on these platforms.
> 
> So we're not invalidating any testing.

Ah, okay. I didn't look at anything but current HEAD. :)

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/