Re: [PATCH 2.6.30 2/4] cxgb3: fix workqueue flush issues

From: David Miller
Date: Mon Apr 20 2009 - 05:08:56 EST


From: Divy Le Ray <divy@xxxxxxxxxxx>
Date: Fri, 17 Apr 2009 15:21:17 -0700

> The fatal error task can be scheduled while processing an offload packet
> in NAPI context when the connection handle is bogus. this can race
> with the ports being brought down and the cxgb3 workqueue being flushed.
> Stop napi processing before flushing the work queue.
>
> The ULP drivers (iSCSI, iWARP) might also schedule a task on keventd_wk
> while releasing a connection handle (cxgb3_offload.c::cxgb3_queue_tid_release()).
> The driver however does not flush any work on keventd_wq while being unloaded.
> This patch also fixes this.
>
> Also call cancel_delayed_work_sync in place of the the deprecated
> cancel_rearming_delayed_workqueue.
>
> Signed-off-by: Divy Le Ray <divy@xxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/