Re: [PATCH/RFC] crypto: compress - Return produced bytes in crypto_{,de}compress_{update,final}()(was: Re: [PATCH/RFC] crypto: compress - Add comp_request.total_out

From: Phillip Lougher
Date: Mon Apr 20 2009 - 19:45:40 EST


Geert Uytterhoeven wrote:
On Mon, 20 Apr 2009, Herbert Xu wrote:
On Tue, Mar 24, 2009 at 05:33:01PM +0100, Geert Uytterhoeven wrote:
Here's an alternative patch, which does exactly that.
Phillip, what do you think?

Thanks for your comments!

>From be7d630f96a85d3ce48716b8e328563ba217647b Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
Date: Tue, 24 Mar 2009 17:19:05 +0100
Subject: [PATCH] crypto: compress - Return produced bytes in crypto_{,de}compress_{update,final}()

If crypto_{,de}compress_{update,final}() succeed, return the actual number of
bytes produced instead of zero, so their users don't have to calculate that
theirselves.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
I certainly prefer this version over the other one? Do you want to
submit crypto API portion of this?

If you think I should submit it now, I can do it. But I'm still waiting for
Phillip's comments.


I think I said they looked OK to me. But, I want to do performance tests
to see if there's any performance degradation over vanilla zlib, and see
if they cope gracefully with corrupted filesystems.

Herbert, are the other cryto API patches in linux-next (or any other
git repository)?

Thanks

Phillip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/