Re: [PATCH] drivers: memory_open cleanup - lookup minor devicenumber from devlist

From: Andrew Morton
Date: Mon Apr 20 2009 - 20:06:07 EST


On Mon, 20 Apr 2009 01:05:23 -0300
Adriano dos Santos Fernandes <adrianosf@xxxxxxxxxx> wrote:

> memory_open ignores devlist and does a switch for each item, duplicating
> code
> and conditional definitions.
>
> Clean it adding backing_dev_info to devlist and use it to lookup for the
> minor
> device.

The patch looks reasonable, however your email client replaced all tabs
with spaces and I didn't really feel like fixing it all up.

I wonder what the lock_kernel() calls in memory_open() are doing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/