Re: [PATCH v2] Fix i_mutex handling in nfsd readdir

From: Al Viro
Date: Mon Apr 20 2009 - 20:29:55 EST


> Sorry for the delay. Simpler might be just to drop and reacquire the
> mutex each time through nfsd4_list_rec_dir()'s loop, but I'd just as
> soon rework the called functions to expect the mutex be held (and get
> rid of the unused, probably fragile, clear_clid_dir() in the process).
>
> So the following could be folded in to your patch.
>
> I tested the combined patch over 2.6.30-rc2. I also tested 2.6.29 +
> 05f4f678 + the combined patch. Both look OK. Feel free to add a
> tested-by or acked-by for "J. Bruce Fields" <bfields@xxxxxxxxxxxxxx> as
> appropriate. Or happy to add a s-o-b and shepherd it along myself if
> it's easier....

I can take both, but if you prefer to have that one go through nfs tree -
fine by me.

I'm going to push a queue into for-next in a couple of hours; running build
tests right now. Patch from dwmw2 is in there...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/