Re: [PATCH] go7007: Convert to the new i2c device binding model

[Clemens Ladisch]

Jean Delvare wrote:
> I am puzzled by the s2250 I2C address, 0x86 really doesn't fit in
> 7 bits, there must be something wrong.

> -				.addr	= 0x34,
> +				.addr	= 0x86,	/* ?? */

> -#define S2250_VIDDEC        0x86

Many I2C controllers use an 8-bit address register, with the lowest bit
being the read/write bit (because this is the order in which the bits
are transmitted over the bus).  So it looks as if the actual address
_is_ 0x34; the S2250_VIDDEC symbol is probably a relict of the old
driver that programmed the I2C controller directly.


Best regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/