Re: [PATCH 3/3] tracing/filters: disallow newline as delimeter

[Ingo Molnar]

* Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> > * Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> > 
> >> Ingo Molnar wrote:
> >>> * Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> >>>
> >>>> I guess because user input is often ended with '\n' (like "echo 
> >>>> xxx"), thus '\n' is used as a delimeter besides ' ', but we can 
> >>>> just strip tailing spaces.
> >>> Hm, how about:
> >>>
> >>> ( echo 'x'
> >>>   echo '|| y' ) > filter
> >>>
> >>> type of scripts? Shouldnt the parser be permissive in general?
> >>>
> >> This patch doesn't forbid this usage: ;)
> >>
> >> ( echo 'parent_comm == a'
> >>   echo '|| parent_comm == b' ) > filter
> >>
> >> This patch does forbid this usage:
> >>
> >> ( echo 'parent_comm'
> >>   echo '=='
> >>   echo 'a' ) > filter
> > 
> > Same argument though, no?
> > 
> 
> Then I have no strong opinion on this. I'm fine to drop this patch.

I've applied the other two - no strong opinion either about this 
patch. Tom, what do you think? (there's also some new parser in the 
works i suspect)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/