Re: [PATCH 07/14] block: reorganize request fetching functions

From: Christoph Hellwig
Date: Tue Apr 21 2009 - 13:08:27 EST


On Wed, Apr 22, 2009 at 01:37:54AM +0900, Tejun Heo wrote:
> Impact: code reorganization
>
> elv_next_request() and elv_dequeue_request() are public block layer
> interface than actual elevator implementation. They mostly deal with
> how requests interact with block layer and low level drivers at the
> beginning of rqeuest processing whereas __elv_next_request() is the
> actual eleveator request fetching interface.
>
> Move the two functions to blk-core.c. This prepares for further
> interface cleanup.

As a follow-up patch you might want to rename them to have a more
descriptive prefix than elv_ and add some kerneldoc comments for them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/