Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]

From: Bartlomiej Zolnierkiewicz
Date: Tue Apr 21 2009 - 15:01:34 EST


On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function âpmac_ide_init_devâ:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> âcheck_media_bay_by_baseâ
> drivers/ide/pmac.c: In function âpmac_ide_setup_deviceâ:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> âmedia_bay_set_ide_infosâ
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---

Should be fixed by:

From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Subject: [PATCH] ide-pmac: fix modular build for CONFIG_PMAC_MEDIABAY=y

On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function âpmac_ide_init_devâ:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> âcheck_media_bay_by_baseâ
> drivers/ide/pmac.c: In function âpmac_ide_setup_deviceâ:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> âmedia_bay_set_ide_infosâ
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---

IDE PMAC host driver can be modular now so we need to export
check_media_bay_by_base() and media_bay_set_ide_infos().

Reported-by: Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
---
drivers/macintosh/mediabay.c | 2 ++
1 file changed, 2 insertions(+)

Index: b/drivers/macintosh/mediabay.c
===================================================================
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -447,6 +447,7 @@ int check_media_bay_by_base(unsigned lon

return -ENODEV;
}
+EXPORT_SYMBOL_GPL(check_media_bay_by_base);

int media_bay_set_ide_infos(struct device_node* which_bay, unsigned long base,
int irq, ide_hwif_t *hwif)
@@ -486,6 +487,7 @@ int media_bay_set_ide_infos(struct devic

return -ENODEV;
}
+EXPORT_SYMBOL_GPL(media_bay_set_ide_infos);
#endif /* CONFIG_BLK_DEV_IDE_PMAC */

static void media_bay_step(int i)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/