Re: [PATCH 1/7] mach-mmp: add parameter to clksrc_read()

From: Eric Miao
Date: Thu Apr 23 2009 - 02:18:21 EST


This looks to be already fixed by Magnus Damm and merged in recent -rc3.

On Thu, Apr 23, 2009 at 3:04 AM, Coly Li <coly.li@xxxxxxx> wrote:
> After the patch to add parameter to uv_read_rtc(), I did a grep and found
> several similar issues.
>
> This patch modifies parameter of clksrc_read() from 'void' to 'struct
> clocksource *cs', which fixes compile warning for incompatible parameter type.
>
> Signed-off-by: Coly Li <coly.li@xxxxxxx>
> Cc: Eric Miao <eric.miao@xxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> ---
> Âarch/arm/mach-mmp/time.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/time.c b/arch/arm/mach-mmp/time.c
> index b03a6ed..a8400bb 100644
> --- a/arch/arm/mach-mmp/time.c
> +++ b/arch/arm/mach-mmp/time.c
> @@ -136,7 +136,7 @@ static struct clock_event_device ckevt = {
>    Â.set_mode    = timer_set_mode,
> Â};
>
> -static cycle_t clksrc_read(void)
> +static cycle_t clksrc_read(struct clocksource *cs)
> Â{
> Â Â Â Âreturn timer_read();
> Â}
>
> --
> Coly Li
> SuSE Labs
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



--
Cheers
- eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/