Re: [patch 2/2] x86 amd fix cmpxchg read acquire barrier

From: Ingo Molnar
Date: Thu Apr 23 2009 - 04:09:08 EST



* Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:

> " // Opteron Rev E has a bug in which on very rare occasions a locked
> // instruction doesn't act as a read-acquire barrier if followed by a
> // non-locked read-modify-write instruction. Rev F has this bug in
> // pre-release versions, but not in versions released to customers,
> // so we test only for Rev E, which is family 15, model 32..63 inclusive.

Dunno. The fix looks a bit intrusive (emits a NOP even on good
CPUs). Also, the text above says "not in versions released to
customers".

So unless there's an official erratum or reports in the field (not
from early prototype systems shipped to developers) i'd not rush to
apply it, just yet.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/