Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled

From: Mike Frysinger
Date: Thu Apr 23 2009 - 11:07:52 EST


On Thu, Apr 23, 2009 at 11:02, Alessandro Zummo wrote:
> On Thu, 23 Apr 2009 23:51:41 +0900 (JST) Atsushi Nemoto wrote:
>> The IRQF_DISABLED fixes would be better regardless of the
>> rtc_update_irq() API change. ÂAnd local_irq_disable fixes are not
>> needed (and should be reverted) if the API change was acked, but no
>> harm for short term fix.
>
> ÂAs I said in my last email to Andrew, I think we can call
> Ârtc_update_irq with irqs enabled and we don't probably need
> Âany IRQF_ to request_irq .
>
> ÂAre you willing to make some tests in that direction with your
> Âdrivers?

we just removed the shared bit from the Blackfin rtc driver because it
didnt really make sense for us. i need to test something else, so is
the only change you need is the one posted originally ? that makes
more sense to me than forcing everyone to use IRQF_DISABLED.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/