Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable withirqs enabled

[Alessandro Zummo]

On Thu, 23 Apr 2009 12:02:48 -0700
David Brownell <david-b@xxxxxxxxxxx> wrote:

> >  as I stated in the email to Andrew.
> > 
> >  do you agree? :)  
> 
> If (rtc_update_irq() starts disabling them locally,
> 	&& its interface stops requiring callers to do that)
> then
> 	it's fine;
> 

 but why rtc_update_irq should disable the IRQs? I believe
 it can work just fine with IRQs enabled.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/