Re: [PATCH 1/5] ftrace: use module notifier for function tracer

[Anders Kaseorg]

On Wed, 22 Apr 2009, Masami Hiramatsu wrote:
> Could you also add "use text_poke() on x86" to your plan? :-)

That should be possible now that it is usable inside stop_machine().  It 
would be nicer to have an API that isnât x86-specific, though.

Another issue is that Ksplice supports patching rodata as well as text, 
and text_poke() does not support changes bigger than PAGE_SIZE.  Though 
perhaps text_poke() is not the right function for rodata patches anyway.

> Hmm, I can't agree that we allow module to modify kernel text...
> Is that possible to separate kernel-text swapping routine from Ksplice
> module? In that case, we don't need to export text_mutex.

No, itâs not enough for Ksplice to lock the kernel text only while 
actively swapping it.  We also need to prevent changes to the kernel text 
while Ksplice is doing run-pre matching to ensure safety.  This means that 
Ksplice wants to hold text_mutex for essentially the entire time itâs 
running.

Anders
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/