Re: [PATCH v2] Maxim 1586 regulator driver

[Mark Brown]

On Thu, Apr 23, 2009 at 08:10:43PM +0200, Robert Jarzmik wrote:

> +/*
> + * max1586.c  --  Voltage and current regulation for the Maxim 1586
> + *
> + * Copyright (C) 2008 Robert Jarzmik

You're living in the past here!

> +/*
> + * V6 voltage
> + * On I2C bus, sending a "x" byte to the max1586 means :
> + *   set V6 to either 0V, 1.8V, 2.5V, 3V depending on (x & 0x3)
> + * As regulator framework doesn't accept voltages to be 0V, we use 1uV.
> + */

Having seen the regulation constraints you're using on your board I'm
thinking even more that it'd be better to implement enable and disable
operations for the driver.  On the other hand, the driver is useful now
and my other comments are all very much nitpicks so from my point of
view:

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

> +	dev_dbg(&client->dev, "changing voltage v6 to %dmv\n",
> +		max1586_v6_calc_voltage(selector) / 1000);

mv should be mV.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/