Re: [patch 2/2] slub: addDocumentation/ABI/testing/sysfs-kernel-slab

[David Rientjes]

On Thu, 23 Apr 2009, Christoph Lameter wrote:

> > I'm more concerned with the userspace API.  You're comfortable with
> > letting userspace determine what allocator the kernel is using either by
> > testing for the presence of certain slub or slqb-specific files or
> > checking the config?
> 
> Why would userspace have to test? If the fields have the same semantics
> then we are fine.
> 

For a robust init script to determine which allocator the kernel is using, 
it must either do `zgrep CONFIG_SLQB=y /proc/config.gz` or 
if [ -e /sys/kernel/slab/cache/hiwater ], for example.  The latter is more 
delicate because the API could change or (even worse) another allocator, 
present or future, could include a `hiwater' attribute.

> > That should be fine since there's parity among the files that both
> > allocators share, but seems fragile if an allocator adds a file that was
> > previously only applicable to the other or the API happens to change.
> 
> Right. The newly added file must not be in use by another allocator.
> 

Yeah, at least with different semantics or side effects.

> > My thinking was that /sys/kernel/slqb would be a permanent reference point
> > that userspace could easily test to determine what API is available.
> 
> The API is hopefully generic enought to accomodate all allocators.
> 

Ok, fair enough.

SLQB will need to update this file and hopefully it doesn't become too 
terribly complex.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/