Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros.

[Sam Ravnborg]

On Sat, Apr 25, 2009 at 10:11:09PM -0400, Tim Abbott wrote:
> This has the consequence of changing the section name use for head
> code from ".text.head" to ".head.text".  Since this commit changes all
> users in the architecture, this change should be harmless.
> 
> Signed-off-by: Tim Abbott <tabbott@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> ---
>  arch/x86/boot/compressed/Makefile         |    2 +
>  arch/x86/boot/compressed/head_32.S        |    3 +-
>  arch/x86/boot/compressed/head_64.S        |    3 +-
>  arch/x86/boot/compressed/vmlinux_32.lds   |   43 -------------------------
>  arch/x86/boot/compressed/vmlinux_32.lds.S |   45 ++++++++++++++++++++++++++
>  arch/x86/boot/compressed/vmlinux_64.lds   |   48 ---------------------------
>  arch/x86/boot/compressed/vmlinux_64.lds.S |   50 +++++++++++++++++++++++++++++
>  arch/x86/kernel/head_32.S                 |    2 +-
>  arch/x86/kernel/head_64.S                 |    2 +-
>  arch/x86/kernel/vmlinux_32.lds.S          |    4 +-
>  arch/x86/kernel/vmlinux_64.lds.S          |    2 +-
>  11 files changed, 106 insertions(+), 98 deletions(-)
>  delete mode 100644 arch/x86/boot/compressed/vmlinux_32.lds
>  create mode 100644 arch/x86/boot/compressed/vmlinux_32.lds.S
>  delete mode 100644 arch/x86/boot/compressed/vmlinux_64.lds
>  create mode 100644 arch/x86/boot/compressed/vmlinux_64.lds.S


You should split this patch up in smaller pieces.
1) Rename from *lds to *.lds.S (and no other changes)
2) Introduce __HEAD & friends
   And as before do not use HEAD_TEXT_SECTION

But otherwise it looks good. I will take a second look
when new patches are sent.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/