Re: [PATCH 10/30] microblaze_mmu_v1: Context handling - mmu_context.c/h

[Arnd Bergmann]

On Monday 27 April 2009, monstr@xxxxxxxxx wrote:
>  arch/microblaze/include/asm/mmu_context.h |  134 +++++++++++++++++++++++++++++
>  arch/microblaze/mm/mmu_context.c          |   70 +++++++++++++++
>  2 files changed, 204 insertions(+), 0 deletions(-)
>  create mode 100644 arch/microblaze/mm/mmu_context.c
> 

Your mmu_context.h is basically

#ifdef CONFIG_MMU
 /* MMU code */
#else
 /* NOMMU code */
#endif

but doesn't have any shared code at all. In cases like this, I'd
recommend having three separate files as m68k does: mmu_context_no.h
mmu_context_mm.h and mmu_context.h that has a simple switch between
them.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/