Re: [PATCH] fsldma: use PCI Read Multiple command

From: Ira Snyder
Date: Mon Apr 27 2009 - 16:42:29 EST


On Mon, Apr 27, 2009 at 03:26:36PM -0500, Timur Tabi wrote:
> David Hawkins wrote:
>
> > PRC_RM - PCI read multiple
> > The default PCI read command used by the DMA controller is
> > PCI Read (PCI command 6h). When the burst length is 32-bytes
> > or longer, PCI Read Line (PCI command Eh) is used (undocumented
> > feature of the controller). Using PCI read multiple
> > (PCI command Ch) results in high-performance across PCI
> > bridges. DMA transfers to non-prefetchable PCI registers
> > should not result in prefetched reads, even when using
> > the PCI read multiple command.
>
> I was thinking more along the lines of:
>
> "This driver tells the DMA controller to use the PCI Read Multiple
> command, instead of the PCI Read Line command, for PCI read operations.
> Please be aware that this setting may result in read pre-fetching on
> some platforms."
>

How about the following revised patch? Is it ok to inline it this way,
or should I send another email to the list containing just this patch?