Re: [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPUring buffer

From: Andi Kleen
Date: Tue Apr 28 2009 - 06:33:36 EST



We're talking about Machine Check Exceptions here, right?

No, this is actually more about machine check events (CMCI or poll), not int #18.

Is there a
valid scenario where you care about performance?

Yes corrected errors. They just get reported while the system
keep running.

In practice they can happen in bursts for a relatively short time.
Another case was dumb QA setups where people using high frequency
injection of corrected errors (that was one case the old code didn't handle
too well). Yes I would agree with you that long term high frequency is
not an interesting case still.

However there's another reason why this patchkit is very useful. The old
code didn't scale to a large number of CPUs, that is why the per CPU
buffers are needed.

Also, it sounds like something that might fit the ftrace ringbuffer
thingy.

We went over this before. Please read this relevant threads.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/