Re: [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c

From: Oleg Nesterov
Date: Tue Apr 28 2009 - 18:41:10 EST


On 04/29, Oleg Nesterov wrote:
>
> - prstatus->pr_ppid = task_pid_vnr(p->parent);
> + prstatus->pr_ppid = task_pid_vnr(p->real_parent);
> prstatus->pr_pgrp = task_pgrp_vnr(p);

Hmm. Just noticed. What protects ->parent or ->real_parent ?

Looks like we need rcu_lock() around... The same in fs/binfmt_elf.c.
Will send another trivial patch (on top of this) tomorrow.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/