Re: [PATCH 02/13] x86, vmlinux.lds: unify header/footer

From: Sam Ravnborg
Date: Wed Apr 29 2009 - 04:23:29 EST


On Wed, Apr 29, 2009 at 10:14:59AM +0200, Ingo Molnar wrote:
>
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
> >
> > * Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> >
> > > Merge everything except PHDRS and SECTIONS into
> > > vmlinux.lds.S
> > > No functional changes.
> > >
> > > This include the removal of an ancient comment that
> > > Martin Mares wrote this file.
> >
> > > -/* ld script to make i386 Linux
> > > - * Written by Martin Mares <mj@xxxxxxxxxxxxxxxxxxxxxxxx>;
> >
> > That's a historic copyright notice in essence which we should not
> > remove - we should preserve that as:
> >
> > > + Original 32-bit version written by Martin Mares <mj@xxxxxxxxxxxxxxxxxxxxxxxx>
> >
> > (preferably with a date-of-that-original-patch inserted as well)
>
> I've added these credits:
>
> +/*
> + * ld script for the x86 kernel
> + *
> + * Historic 32-bit version written by Martin Mares <mj@xxxxxxxxxxxxxxxxxxxxxxxx>
> + *
> + * Modernisation and unification done by Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> is that fine to you?

OK.
Albeit in general I do not add stuff like that myself.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/