Re: [PATCH 04/29] x86/perfcounters: reworkpmc_amd_save_disable_all() and pmc_amd_restore_all()

[Ingo Molnar]

* Paul Mackerras <paulus@xxxxxxxxx> wrote:

> Ingo Molnar wrote:
> 
> > Could we remove the disable-all facility altogether and make the 
> > core code NMI-safe? The current approach wont scale on CPUs that 
> > dont have global-disable features.
> > 
> > disable-all was arguably a hack i introduced and which spread 
> > too far. Can you see a conceptual need for it?
> 
> If you're talking about hw_perf_save_disable / hw_perf_restore, 
> please don't get rid of those.  I use them to batch up counter 
> enable/disable operations so I only have to compute the PMU config 
> once for each batch rather than every time an individual counter 
> is enabled or disabled.

ok, sure.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/