Re: [PATCH] clear irq pending when bypassing it

[Joe Korty]

On Thu, Apr 30, 2009 at 12:49:39PM -0400, Eric W. Biederman wrote:
> Joe Korty <jak@xxxxxxxxxxxxxxxx> writes:
> 
> > IRQ_MOVE_PENDING must be cleared whenever it is bypassed.
> >
> > Otherwise, we risk an old, pending affinity change
> > overtaking and erasing a more recent affinity change that
> > had been directly applied (eg, IRQ_MOVE_PCNTXT mode).
> 
> When can this happen?

Probably doesn't happen.  AFAIK, each IRQ is either fully MSI
or non-MSI.  The MSI IRQs will always use IRQ_MOVE_PCNTXT and
the non-MSI's will never use IRQ_MOVE_PCNTXT.  Thus no collision.

It could only happen if it was possible for a MSI and non-MSI
device to share an IRQ.

Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/