Re: iwlwifi: remove EXPORT_SYMBOL for static symbol

[reinette chatre]

Andreas,

On Thu, 2009-04-30 at 10:27 -0700, Andreas Schwab wrote:
> 
> reinette chatre
> <reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@xxxxxxxxxxxxxxxx> writes:
> 
> > On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> >> It does not make sense to apply EXPORT_SYMBOL to a static symbol.  Fixes
> >> this build error:
> >> 
> >> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> >> 
> >> Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@xxxxxxxxxxxxxxxx>
> >> ---
> >> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> >
> >>From which repo is this commit id? 
> 
> That's from davem/net-2.6 or linville/wireless-2.6.git


Thanks. Even though this patch obsoletes
6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have
that patch in the repo as it removes another unnecessary EXPORT_SYMBOL.
I would thus prefer that both patches are included.

Reinette

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/