Re: What's in hid.git for 2.6.30

From: Oliver Neukum
Date: Fri May 01 2009 - 05:03:48 EST


Am Friday 01 May 2009 01:09:12 schrieben Sie:
> On Fri, 1 May 2009, Oliver Neukum wrote:
> > > --- a/drivers/hid/hid-core.c
> > > +++ b/drivers/hid/hid-core.c
> > > @@ -1824,6 +1824,9 @@ int hid_check_keys_pressed(struct hid_device
> > > *hid) struct hid_input *hidinput;
> > > ÂÂÂÂÂÂÂÂint i;
> > > Â
> > > +ÂÂÂÂÂÂÂif (!(hid->claimed & HID_CLAIMED_INPUT))
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn 0;
> > > +
> >
> > is there a guarantee all keyboards will be claimed as input devices?
>
> Hi Oliver,
>
> do you see any way how hid->inputs could currently be initialized other
> than the device being claimed by hid-input?

No, but I am worried about a false return of 0 here, not the other way
round. This method is necessary because keyboards don't wake up
if a key is released. Suspending a keyboard with a key pressed will lead
to an endless repetition of that key.
So I wonder whether it is possible to have a keyboard not claimed as an
input device.

Regards
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/