Re: [PATCH 04/27] asm-generic: add legacy I/O header files

From: Arnd Bergmann
Date: Fri May 01 2009 - 09:57:16 EST


On Friday 01 May 2009, Alan Cox wrote:
> They shouldn't define it - we want those invalid cases to error. Stick
> CLOCK_TICK_RATE in the depths of the x86 arch includes and then we can
> fix the other cases properly. Either the device has an independant clock
> of the same frequency (some watchdogs do this), it relies upon a
> motherboard timer in which case the platform can define CLOCK_TICK_RATE
> (or a better name for it), or it doesn't have any meaning in which case
> we *want* it not to compile.

I just noticed that linux/jiffies.h does not compile without a definition
of CLOCK_TICK_RATE, so that's probably why every architecture defines it.
If I find a way to remove that dependency, I can simply leave out the
CLOCK_TICK_RATE from the generic header. I have not yet understood the
relation of jiffies to CLOCK_TICK_RATE, but my suspicion is that it's
not good for architectures that do not have a clock tick.

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/