Re: [PATCH 0/4] PM: Drop shrink_all_memory (rev. 2) (was: Re: [PATCH 3/3] PM/Hibernate: Use memory allocations to free memory)

From: Rafael J. Wysocki
Date: Mon May 04 2009 - 15:53:46 EST


On Monday 04 May 2009, Pavel Machek wrote:
> Hi!
>
> > I know that swsusp_shrink_memory() has problems, that's why I'd like to get rid
> > of it.
> >
> > > I wonder if it's possible to free up the memory within 1s at all.
> >
> > I'm not sure.
> >
> > Apparently, the counting of saveable pages takes substantial time (0.5 s each
> > iteration on my 64-bit test box), so we can improve that by limiting the number
> > of iterations.
>
> We could increase step size after each step. Free in 40MB step, then
> 80MB step, then 160MB step, ...

Why not just one step? It doesn't seem to hurt performance AFAICS.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/