Re: [PATCH 1/4] pci/x86: don't assume pref memio are 64bit -v4

From: Jesse Barnes
Date: Tue May 05 2009 - 14:53:18 EST


On Thu, 23 Apr 2009 20:48:32 -0700
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

>
> we should not assign 64bit range to pci device that only take 32bit
> pref
>
> try to set IORESOURCE_MEM_64 in 64bit resource of
> pci_device/pci_bridge and make the bus resource only have that bit
> set when all device under that do support 64bit pref mem then use
> that flag to allocate resource in wanted area
>
> v2: fix b_res->flags and logic and passing result.
> v3: split iomem to iomem32, iomem64, and iomem64 will take
> IORESOURCE_MEM_64 V4: according to Ivan
> make it support x86 only, by PCIBIOS_MAX_MEM_32
> double check if the bridge does support pref mem64 with
> write/read UPPER32
>
> [Impact: do assign wrong range to device that doesn't support it]

Thanks a lot Yinghai & Ivan, I applied 1 & 2 (the other 2 e820 patches
should go through Ingo), they're in my linux-next branch.

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/