Re: [PATCH 1/3] ptrace: ptrace_attach: check PF_KTHREAD +exit_state instead of ->mm

From: Ingo Molnar
Date: Wed May 06 2009 - 03:42:19 EST



* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Tue, May 05, 2009 at 04:47:33PM -0700, Andrew Morton wrote:
> > These patches make a mess of utrace-core.patch. Do we really want to do that?
>
> Yes. All these patches from Oleg are preparations for actually
> doing a utrace merge in a sane way. I don't really think utrace
> should be in -mm at this point where active ptrace work is going
> on.

Yes, as i said it in earlier threads, lacking other in-tree use,
utrace is only acceptable for upstream if it materially cleans up
the ptrace code here and now - without any wide #ifdefs like some of
the earlier patches did.

The latest patches from Oleg clearly go in this direction, which is
a very promising development!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/