[PATCH 4/5] do_wait: kill the old BUG_ON, use while_each_thread()

From: Oleg Nesterov
Date: Thu May 07 2009 - 02:52:17 EST


do_wait() does BUG_ON(tsk->signal != current->signal), this looks like
a raher obsolete check. At least, I don't think do_wait() is the best
place to verify that all threads have the same ->signal. Remove it.

Also, change the code to use while_each_thread().

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
---

kernel/exit.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--- PTRACE/kernel/exit.c~4_WHILE 2009-05-07 05:09:51.000000000 +0200
+++ PTRACE/kernel/exit.c 2009-05-07 05:34:40.000000000 +0200
@@ -1595,9 +1595,7 @@ repeat:

if (wo->wo_flags & __WNOTHREAD)
break;
- tsk = next_thread(tsk);
- BUG_ON(tsk->signal != current->signal);
- } while (tsk != current);
+ } while_each_thread(current, tsk);
read_unlock(&tasklist_lock);

notask:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/