Re: [Xen-devel] [PATCH 2/5] xen/x86-64: clean up warnings aboutIST-usingtraps

From: Jeremy Fitzhardinge
Date: Fri May 08 2009 - 11:23:23 EST


Jan Beulich wrote:
else if (addr == (unsigned long)int3)
addr = (unsigned long)xen_int3;
- else
- WARN_ON(val->ist != 0);
+ else if (addr == (unsigned long)double_fault ||
+ addr == (unsigned long)stack_segment) {

I don't think you want to exclude handling stack faults: Ordinary memory
references using rsp or rbp as the base register will cause these instead
of general protection faults when the resulting effective address is non-
canonical.

So even usermode memory accesses? Ew. Well, we can run the trap handler on the normal kernel stack in that case. I'll cook something up.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/