Re: [PATCH] x86 MCE: shut up lockdep warning

From: Andi Kleen
Date: Fri May 08 2009 - 15:06:27 EST


> So was this a genuine bug in your code? The patch suggests it was.

No I think it was false. See my earlier email.

The higher level cpu_add_remove_lock makes sure that there is never
an interrupt when the code is running process context.

So Ingo's patch shuts off lockdep, but it's overkill and not really
needed. It would be better if there was some way to express
the dependency on cpu_add_remove_lock, but I'm not sure
that can be expressed in lockdep.

-Andi


--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/