Re: [PATCH 05/14] kbuild: allow compressors (gzip, bzip2, lzma) totake multiple inputs

From: H. Peter Anvin
Date: Fri May 08 2009 - 16:54:22 EST


Sam Ravnborg wrote:

I did a quick attempt to integrate it in the Makefile - not pretty.
So I dropped that idea.

It is mainly that we should not fill up scripts/ with small
undocumented scripts.

Could you add something like this in the top of the file:

# Find the sum of the size of all files specified and
# output the size as an escaped hex string.
#
# Sample:
# $ ls -l foo
# $ -rw-rw-r-- 1 xxx xxx 146 May 8 22:28 foo
# $ bin_size foo
# $ \\x92\\x00\\x00\\x00
# 146 equals 92 hex


OK, I see your point (especially since that's not what it does.)

To be honest, how ugly would it be to get a C program in here? Doing this in shell is horrid, and people tend to whine about Perl (which is perfect for this kind of job.)

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/