Re: [PATCH] x86: fix node_possible_map logic

From: David Rientjes
Date: Fri May 08 2009 - 18:47:24 EST

Next message: Rafael J. Wysocki: "Re: [TuxOnIce-devel] [RFC] TuxOnIce"
Previous message: akpm: "mmotm 2009-05-08-15-22 uploaded"
In reply to: Yinghai Lu: "Re: [PATCH] x86: fix node_possible_map logic"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, 8 May 2009, Yinghai Lu wrote:

> Jack Steiner wrote:
> > On Fri, May 08, 2009 at 12:43:01AM -0700, Yinghai Lu wrote:
> >> recently there are some changes to about meaning of node_possible_map
> >>
> >> and it is some strange:
> >> the node without memory would be set in node_possible_map
> >> but some node with less NODE_MIN_SIZE will be kicked out of node_possible_map.
> >>
> > ...
> >
> > I tried this patch on a system with
> > - latest linux-next
> > - 2 Nehelem sockets
> > - no memory on socket 0
> > - 256MB on socket 1
> >
> > I still see a panic in early boot. Here is the console output:
> > (Note - this is from a system simulator - not real hardware. However, I don't
> > believe the problem is related to the simulator (but would never rule it out).
> >
> > The panic is at least partially the result of a NULL entry in the
> > node_data[] array.
> >
> > I'll try to do more debugging later this weekend....
> >
> > --- jack
> >
> > --------------------
> >
> >
> > <6>Initializing cgroup subsys cpuset
> > <6>Initializing cgroup subsys cpu
> > <5>Linux version 2.6.30-rc4-next-20090505-medusa (steiner@xxxxxxxxxxxxxxxxxxxxxxxxx) (gcc version 4.2.4) #43 SMP Fri May 8 07:26:02 CDT 2009
> > <6>Command line: root=/dev/hda2 init=/bin/bash console=ttyS0,38400n8 fprom lpj=10000 nohpet loglevel=8 iommu=off dma32_size=4096
> > <6>KERNEL supported cpus:
> > <6> Intel GenuineIntel
> > <6> AMD AuthenticAMD
> > <6> Centaur CentaurHauls
> > <6>BIOS-provided physical RAM map:
> > <6> BIOS-e820: 0000000000000000 - 0000000000006000 (usable)
> > <6> BIOS-e820: 0000000000006000 - 0000000000200000 (reserved)
> > <6> BIOS-e820: 0000000000200000 - 0000000010000000 (usable)
> > <6> BIOS-e820: 0000000080000000 - 0000000090000000 (reserved)
> > <6> BIOS-e820: 00000000f0000000 - 00000000fc000000 (reserved)
> > <6> BIOS-e820: 00000000fed1c000 - 00000000fed20000 (reserved)
> > <6> BIOS-e820: 00000000fff60000 - 00000000fff6c000 (reserved)
> > <6> BIOS-e820: 00000fe000000000 - 00000fe018000000 (reserved)
> > <6>EFI v1.00 by SGI
> > <6> ACPI 2.0=0xe0200 UVsystab=0xe08c0
> > <6>EFI: mem00: type=7, attr=0x8, range=[0x0000000000000000-0x0000000000006000) (0MB)
> > <6>EFI: mem01: type=5, attr=0x8000000000001000, range=[0x0000000000006000-0x00000000000b0000) (0MB)
> > <6>EFI: mem02: type=6, attr=0x8000000000000008, range=[0x00000000000b0000-0x0000000000200000) (1MB)
> > <6>EFI: mem03: type=7, attr=0x8, range=[0x0000000000200000-0x0000000010000000) (254MB)
> > <6>EFI: mem04: type=6, attr=0x8000000000000001, range=[0x0000000080000000-0x0000000090000000) (256MB)
> > <6>EFI: mem05: type=6, attr=0x8000000000000001, range=[0x00000000f0000000-0x00000000fc000000) (192MB)
> > <6>EFI: mem06: type=6, attr=0x8000000000000001, range=[0x00000000fed1c000-0x00000000fed20000) (0MB)
> > <6>EFI: mem07: type=6, attr=0x8000000000000001, range=[0x00000000fff60000-0x00000000fff6c000) (0MB)
> > <6>EFI: mem08: type=11, attr=0x8000000000000001, range=[0x00000fe000000000-0x00000fe018000000) (384MB)
> > <6>DMI not present or invalid.
> > <6>last_pfn = 0x10000 max_arch_pfn = 0x100000000
> > <7>MTRR default type: write-back
> > <7>MTRR fixed ranges enabled:
> > <7> 00000-FFFFF write-back
> > <7>MTRR variable ranges enabled:
> > <7> 0 base 0 F0000000 mask FFF F0000000 uncachable
> > <7> 1 base E0 00000000 mask FF0 00000000 uncachable
> > <7> 2 base F0 00000000 mask FF0 00000000 uncachable
> > <7> 3 base F00 00000000 mask FF0000000000 uncachable
> > <7> 4 disabled
> > <7> 5 disabled
> > <7> 6 disabled
> > <7> 7 disabled
> > <6>x86 PAT enabled: cpu 0, old 0x606060606060606, new 0x7010600070106
> > <6>x2apic enabled by BIOS, switching to x2apic ops
> > <6>init_memory_mapping: 0000000000000000-0000000010000000
> > <7> 0000000000 - 0010000000 page 2M
> > <7>kernel direct mapping tables up to 10000000 @ 936000-938000
> > <4>ACPI: RSDP 00000000000e0200 00024 (v02 )
> > <4>ACPI: XSDT 00000000000e0240 00054 (v01 SGI UVX 00010001 FPRM 00000001)
> > <4>ACPI: APIC 00000000000e02e0 00086 (v01 SGI UVX 00010001 FPRM 00000001)
> > <4>ACPI: SRAT 00000000000e0380 00078 (v01 SGI UVX 00010001 FPRM 00000001)
> > <4>ACPI: SLIT 00000000000e05e0 00030 (v01 SGI UVX 00010001 FPRM 00000001)
> > <4>ACPI: MCFG 00000000000e0640 0004C (v01 SGI UVX 00010001 FPRM 00000001)
> > <4>ACPI: FACP 00000000000e06a0 000F4 (v03 SGI UVX 00030001 FPRM 00000001)
> > <4>ACPI: DSDT 00000000000e02a0 00030 (v01 SGI UVX 00010001 FPRM 00000001)
> > <4>ACPI: FACS 00000000000e07a0 00040
> > <4>ACPI: DMAR 00000000000e0860 0004C (v01 SGI UVX 00010001 FPRM 00000001)
> > <7>ACPI: Local APIC address 0xfee00000
> > <6>Setting APIC routing to cluster x2apic.
> > <6>SRAT: PXM 0 -> APIC 0 -> Node 0
> > <6>SRAT: PXM 1 -> APIC 128 -> Node 1
> > <6>SRAT: Node 1 PXM 1 0-fff6c000
> > <7>NUMA: Using 63 for the hash shift.
> > <6>Bootmem setup node 1 0000000000000000-0000000010000000
> > <6> NODE_DATA [0000000000935a80 - 0000000000969a7f]
> > <6> bootmap [000000000096a000 - 000000000096bfff] pages 2
> > <6>(7 early reservations) ==> bootmem [0000000000 - 0010000000]
> > <6> #0 [0000000000 - 0000001000] BIOS data page ==> [0000000000 - 0000001000]
> > <6> #1 [0000006000 - 0000008000] TRAMPOLINE ==> [0000006000 - 0000008000]
> > <6> #2 [0000200000 - 0000935a5c] TEXT DATA BSS ==> [0000200000 - 0000935a5c]
> > <6> #3 [000009f000 - 00000e0900] BIOS reserved ==> [000009f000 - 00000e0900]
> > <6> #4 [00000e0a68 - 0000100000] BIOS reserved ==> [00000e0a68 - 0000100000]
> > <6> #5 [00000e0900 - 00000e0a68] EFI memmap ==> [00000e0900 - 00000e0a68]
> > <6> #6 [0000001000 - 0000001030] ACPI SLIT ==> [0000001000 - 0000001030]
> > <7> [ffffe20000000000-ffffe200003fffff] PMD -> [ffff880001200000-ffff8800015fffff] on node 1
> > <4>Zone PFN ranges:
> > <4> DMA 0x00000000 -> 0x00001000
> > <4> DMA32 0x00001000 -> 0x00100000
> > <4> Normal 0x00100000 -> 0x00100000
> > <4>Movable zone start PFN for each node
> > <4>early_node_map[2] active PFN ranges
> > <4> 1: 0x00000000 -> 0x00000006
> > <4> 1: 0x00000200 -> 0x00010000
> > <7>On node 1 totalpages: 65030
> > <7> DMA zone: 56 pages used for memmap
> > <7> DMA zone: 1944 pages reserved
> > <7> DMA zone: 1590 pages, LIFO batch:0
> > <7> DMA32 zone: 840 pages used for memmap
> > <7> DMA32 zone: 60600 pages, LIFO batch:15
> > <6>ACPI: PM-Timer IO Port: 0x1008
> > <7>ACPI: Local APIC address 0xfee00000
> > <6>Setting APIC routing to cluster x2apic.
> > <6>ACPI: LSAPIC (acpi_id[0x00] lsapic_id[0x00] lsapic_eid[0x00] enabled)
> > <6>ACPI: LSAPIC (acpi_id[0x01] lsapic_id[0x00] lsapic_eid[0x80] enabled)
> > <6>ACPI: LAPIC_NMI (acpi_id[0x00] high edge lint[0x1])
> > <6>ACPI: LAPIC_NMI (acpi_id[0x01] high edge lint[0x1])
> > <6>ACPI: IOAPIC (id[0x08] address[0xfec00000] gsi_base[0])
> > <6>IOAPIC[0]: apic_id 8, version 0, address 0xfec00000, GSI 0-23
> > <6>ACPI: IOAPIC (id[0x09] address[0xfec80000] gsi_base[24])
> > <6>IOAPIC[1]: apic_id 9, version 0, address 0xfec80000, GSI 24-24
> > <6>ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 high edge)
> > <6>ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level)
> > <7>ACPI: IRQ0 used by override.
> > <7>ACPI: IRQ2 used by override.
> > <7>ACPI: IRQ9 used by override.
> > <6>Using ACPI (MADT) for SMP configuration information
> > <6>SMP: Allowing 2 CPUs, 0 hotplug CPUs
> > <7>nr_irqs_gsi: 25
> > <6>PM: Registered nosave memory: 0000000000006000 - 0000000000200000
> > <6>Allocating PCI resources starting at 18000000 (gap: 10000000:70000000)
> > <6>NR_CPUS:4096 nr_cpumask_bits:2 nr_cpu_ids:2 nr_node_ids:2
>
> looks like we handle node_online_map correctly.
>
> arch/x86/mm/numa_64.c: node_set_online(nodeid);
> arch/x86/mm/numa_64.c: node_set_online(0);
>
> first one in setup_node_bootmem
> second one is fallback.
>
> in initmem_init in numa_64.c, before every try possible_map and online_map are cleared.
>
> so somehow node_online_map is corrupted.
>

As Jack pointed out, node 0 has no memory so there's a discrepency between
a node being online and having memory. The problem here seems to be the
fact that NODE_DATA(0)->node_zones is NULL, which makes sense for its
state.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Rafael J. Wysocki: "Re: [TuxOnIce-devel] [RFC] TuxOnIce"
Previous message: akpm: "mmotm 2009-05-08-15-22 uploaded"
In reply to: Yinghai Lu: "Re: [PATCH] x86: fix node_possible_map logic"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]