Re: [RFC] convert ftrace syscall tracer to TRACE_EVENT()

From: Ingo Molnar
Date: Sat May 09 2009 - 10:07:49 EST



* Frédéric Weisbecker <fweisbec@xxxxxxxxx> wrote:

> > Note, this assumes that all syscall types can be described via
> > __field() - i think that's correct. (we dont want to deref
> > strings as they are untrusted, and there are no arrays in
> > syscall parameters)
>
> Yeah, but we can also define a __string_from_user(), should be
> trivial.

We cannot really do that, because we cannot check the type in a
macro. So we dont know when to inject __field() versus
__string_from_user().

> > Can you see any complication?
>
> Just about the order of headers to include and headers
> dependencies....

That is testable and any problems will be found at the build stage,
so it should be solvable.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/