Re: [v0 PATCH 1/1] Use dev_name() for AMD8111/AMD8131 EDAC driver

[Harry Ciao]

Andrew Morton wrote:
> On Thu,  7 May 2009 09:47:38 +0800
> Harry Ciao <qingtao.cao@xxxxxxxxxxxxx> wrote:
>
>   
> > The device structure no longer has bus_id member, dev_name() should
> > be used for AMD8111 & AMD8131 EDAC driver instead. Also, their Makefile 
> > entries are lost, add them.
> >
> > Signed-off-by: Harry Ciao <qingtao.cao@xxxxxxxxxxxxx>
> > ---
> >  drivers/edac/Makefile       |    2 ++
> >  drivers/edac/amd8111_edac.c |    4 ++--
> >  drivers/edac/amd8131_edac.c |    2 +-
> >  3 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> > index a5fdcf0..5907681 100644
> > --- a/drivers/edac/Makefile
> > +++ b/drivers/edac/Makefile
> > @@ -35,3 +35,5 @@ obj-$(CONFIG_EDAC_MPC85XX)		+= mpc85xx_edac.o
> >  obj-$(CONFIG_EDAC_MV64X60)		+= mv64x60_edac.o
> >  obj-$(CONFIG_EDAC_CELL)			+= cell_edac.o
> >  obj-$(CONFIG_EDAC_PPC4XX)		+= ppc4xx_edac.o
> > +obj-$(CONFIG_EDAC_AMD8111)		+= amd8111_edac.o
> > +obj-$(CONFIG_EDAC_AMD8131)		+= amd8131_edac.o
> >     
>
> hm, I wonder how that happened.
>
> The drivers break x86-64 allmodconfig:
>
> drivers/edac/amd8111_edac.c: In function 'amd8111_lpc_bridge_init':
> drivers/edac/amd8111_edac.c:260: error: implicit declaration of function '__do_inb'
> drivers/edac/amd8111_edac.c:274: error: implicit declaration of function '__do_outb'
>
>
>   

Ah, this is because __do_inb so far only supported on PPC arch:

cao@cao-desktop:/work/community/linux-2.6/arch$ grep __do_inb * -r
powerpc/include/asm/io.h:#define __do_inb(port)        _rec_inb(port)
powerpc/include/asm/io.h:#define __do_inb(port)        
readb((PCI_IO_ADDR)_IO_BASE + port);
cao@cao-desktop:/work/community/linux-2.6/arch$

So far the only machine that hosts AMD8111 chip is Maple, however, 
AMD8111 is of Hypertransport device and not necessarily depends on Maple 
nor PPC, so its Kconfig option is only depended on EDAC && EDAC_MC_EDAC 
&& PCI.

I think I could put some words into its Kconfig help section that 
AMD8111 should be selected on Maple now.

What do you think? thanks!

Best regards,

Harry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/