Re: Probe Timeouts with 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8

[Linus Torvalds]

On Fri, 1 May 2009, Parag Warudkar wrote:

> On 5/1/09, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> 
> > I'm not sure what makes you think that it even _should_ be reverted.
> >  Just to make that clear: it should _not_ be reverted. How did you check
> >  that it isn't reverted in compat-wireless anyway? Must have been by code
> >  inspection since if you had made an attempt to verify that the code in
> >  there works, you would have found that indeed there's no reason to
> >  revert this commit since the fix for it went in, and is literally a
> >  single line.
> 
> Well I have the 04-29 compat-wireless tree and it does not work - just
> like mainline I get timeouts. I have not been able to download later
> versions - clicking on the URL does nothing for some reason. (Besides
> I do not normally track compat-wireless.)

Ok, it's -rc5, and apparently nothing has happened about this problem. 
Johannes has just been stone-walling and ignoring the reports, and 
claiming it's fixed when it clearly wasn't. 

I just verified on one of my older machines (running current fedora-11, 
with a 4965AGN rev=0x4) that the problem is real, and that reverting that 
commit does indeed seem to fix it.

So here goes: I'm going to revert that commit today or tomorrow, unless 
somebody sends me a fix that I can verify. I don't want any more excuses, 
I don't want to hear developers dismissing bug-reports, and I _can_ verify 
this problem myself. 

We do not fix bugs by introducing new regressions and then ignoring the 
reports. Especially since the bug that the commit in question fixes seems 
to be _way_ less important than the bug it then introduces.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/