Re: [PATCH 2/15 -tip] x86: Add cpufeatures for Advanced Power Management

[H. Peter Anvin]

Jaswinder Singh Rajput wrote:
> 1. Add Advanced Power Management (Function 8000_0007h), edx
> 2. unification of X86_FEATURE_CONSTANT_TSC (from intel.c, amd.c to common.c)
> 3. Remove cpu/powerflags.c
> 4. Remove x86_power
> 5. Move 'power management' to flags of /proc/cpuinfo
>
> /proc/cpuinfo (before)
> flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
> mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt
> rdtscp lm 3dnowext 3dnow constant_tsc rep_good nonstop_tsc pni cx16
> lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch osvw skinit pname
> ..
> power management: ts ttp tm stc 100mhzsteps hwpstate
>
> /proc/cpuinfo (after)
> flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
> mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt
> rdtscp lm 3dnowext 3dnow rep_good tsc_reliable nonstop_tsc pni cx16
> lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch osvw skinit pname
> ts ttp htc stc 100mhzsteps hwpstate constant_tsc
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>

NAK in the extreme.

This is an incompatible change to a userspace visible API.  The fact 
that power management flags were separate was braindamage in the first 
place, of course, but we don't break established userspace APIs even if 
they're stupid.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/