Re: [patch 07/11 -mmotm] oom: prevent possible OOM_DISABLE livelock

From: Andrew Morton
Date: Mon May 11 2009 - 17:28:43 EST


On Sun, 10 May 2009 15:07:19 -0700 (PDT)
David Rientjes <rientjes@xxxxxxxxxx> wrote:
>

The changelog perplexes me.

> This moves the check for OOM_DISABLE to the badness heuristic while
> holding task_lock().

why?

> Badness scores of 0 are now explicitly prohibited
> from being oom killed

why?

> and since the oom_adj value is a characteristic of
> an mm and not a task, it is no longer necessary to check the oom_adj
> value for threads sharing the same memory (except when simply issuing
> SIGKILLs for threads in other thread groups).

ok...


The title says that this patch fixes a livelock. But the changelog
didn't describe that livelock and didn't tell us how the patch fixed
it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/