Re: [PATCH 1/1] pci: expose SMBus on Asus notebook A6L

[Robert Hancock]

Mats Erik Andersson wrote:
> From: Mats Erik Andersson <mats.andersson@xxxxxxxxxxxxxx>
>
> Addition of one unknown subsystem identifier to the
> quirks handler for chipset i82855GM_HB on notebook
> Asus A6L. This exposes the otherwise hidden SMBus
> controller within the south bridge ICH4-M.
>
> Signed-off-by: Mats Erik Andersson <mats.andersson@xxxxxxxxxxxxxx>
> ---
>
> Tried and successfully used on kernel 2.6.29 and 2.6.23.17.
>
> --- drivers/pci/quirks.c.orig	2009-05-09 00:47:21.000000000 +0200
> +++ drivers/pci/quirks.c	2009-05-12 11:20:04.000000000 +0200
> @@ -1068,8 +1068,9 @@ static void __init asus_hides_smbus_host
>  		else if (dev->device == PCI_DEVICE_ID_INTEL_82855GM_HB)
>  			switch (dev->subsystem_device) {
>  			case 0x1751: /* M2N notebook */
>  			case 0x1821: /* M5N notebook */
> +			case 0x1897: /* A6L notebook */
>  				asus_hides_smbus = 1;
>  			}
>  		else if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
>  			switch (dev->subsystem_device) {

This has to be done with caution. If the BIOS accesses the SMBus 
controller from ACPI AML code or SMI code, then allowing a Linux driver 
to access the controller may cause problems.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/