Re: [PATCH 0/3] block: completion related functions cleanup

From: Tejun Heo
Date: Thu May 14 2009 - 10:05:36 EST


Boaz Harrosh wrote:
> ---
> drivers/scsi/scsi_lib.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index e410d66..f8600d6 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -789,7 +789,6 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
> */
> if (scsi_end_request(cmd, error, good_bytes, result == 0) == NULL)
> return;
> - this_count = blk_rq_bytes(req);
>
> error = -EIO;
>

Nice spotting. Looks like the variable can be killed completely?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/