Re: [PATCH 6/7] ide: pass number of ports to ide_host_{alloc,add}()

[Sergei Shtylyov]

Hello.

Bartlomiej Zolnierkiewicz wrote:

> > > @@ -467,7 +467,7 @@ icside_register_v6(struct icside_state *
> > >  	struct ide_host *host;
> > >  	unsigned int sel = 0;
> > >  	int ret;
> > > -	hw_regs_t hw[2], *hws[] = { &hw[0], NULL, NULL, NULL };
> > > +	hw_regs_t hw[2], *hws[] = { &hw[0], NULL };
> > >       
> >     I wonder if there's an old bug here since I'm not seeing when hws[1] is 
> > set to non-NULL -- despite there are apparently two ports?
> >
> >     Indeed, this bug seems to date back to the 'struct ide_host' 
> > introduction, see this:
> >  
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=48c3c1072651922ed153bcf0a33ea82cf20df390#patch1...
> >     
>
> Care to send a fix?
>   

  I will...

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/