Re: [PATCH 0/3] fix stale swap cache account leak in memcg v7

From: Daisuke Nishimura
Date: Thu May 14 2009 - 20:51:39 EST


On Fri, 15 May 2009 08:47:16 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> On Wed, 13 May 2009 09:31:27 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
>
> > On Tue, 12 May 2009 15:21:58 +0530
> > Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > > > The patch set includes followng
> > > > [1/3] add mem_cgroup_is_activated() function. which tell us memcg is _really_ used.
> > > > [2/3] fix swap cache handling race by avoidng readahead.
> > > > [3/3] fix swap cache handling race by check swapcount again.
> > > >
> > > > Result is good under my test.
> > >
> > > What was the result (performance data impact) of disabling swap
> > > readahead? Otherwise, this looks the most reasonable set of patches
> > > for this problem.
> > >
> > I'll measure some and report it in the next post.
> >
> I confirmed there are cases which swapin readahead works very well....
>
> Nishimura-san, could you post a patch for fixing leak at writeback ? as [3/3]
> I'd like to fix readahead case...with some large patch.
>
Sure.
I'll rebase my patch onto [1-2/3] of your new patch and post it.

> Hm, I didn't think this problem took 2 months to be fixed ;(
>
I didn't think so either.


Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/