Re: [PATCH 1/3] Introduce "struct wait_info" to simplifywait_task*() pathes

From: Ingo Molnar
Date: Fri May 15 2009 - 13:37:40 EST



* Vitaly Mayatskikh <v.mayatskih@xxxxxxxxx> wrote:

> At Wed, 13 May 2009 11:13:58 -0700 (PDT), Roland McGrath wrote:
>
> > What's the benefit of this? Those parameters are probably
> > happily in registers and compiled well, I would guess. Adding
> > more memory copying does not seem like a benefit. Have you
> > verified that your change reduces code size or something like
> > that?
>
> Yeah, I was wrong. There's no benefit in size of .text

but there's a lot of benefit in cleanliness - just look at the
simplification of the prototypes.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/