Re: [PATCH] ata: libata depends on HAS_DMA

From: Jeff Garzik
Date: Sun May 17 2009 - 16:06:36 EST


Arnd Bergmann wrote:
On Sunday 17 May 2009, Robert Hancock wrote:
Please reread my explanations above and your own reply from last thursday. The case is entirely theoretical, as all platforms
(except microblaze, which is getting fixed) either set HAS_DMA or
don't allow building ATA drivers anyway. Platforms that don't support
DMA can just define CONFIG_HAS_DMA and do what you suggested:

On Thursday 14 May 2009, Robert Hancock wrote:
Wouldn't the easiest solution be to just dummy out the DMA API calls on this platform to always fail? That would fix these compile problems..


That's what needs to happen. We provide no-op functions for e.g. PCI and x86 DMI, for platforms where this support does not exist.

Pretty much all architectures support some form of ATA. m68k, m32r, h8300 and microblaze all have IDE interface, which means that libata needs to work on that platform.

The only !ATA arch in the entire kernel is s390, AFAICT.

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/