Re: [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>(

[Joe Perches]

On Mon, 2009-05-18 at 15:56 +0000, James Bottomley wrote:
> What exactly is the point of a mechanical conversion from
> printk(KERN_ ...) to pr_...?
> 
> I can see the value of the pr_ macros from new code in that the
> temptation to put a comma after KERN_.. for some people is irresistible
> so it's an interface that's very easy to misuse, but given that we have
> correct uses, why convert them?

Enables easier conversion to dev_<foo> macros
Allows easier prefixing via pr_fmt
Puts back together unnecessarily chopped up format strings
Standardization is good
Just for the hell of it

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/