Re: [PATCH] mm/slub.c: change printk()s to pr_*() notation

From: Pekka Enberg
Date: Wed May 20 2009 - 08:33:23 EST


On Tue, May 19, 2009 at 9:03 PM, H Hartley Sweeten
<hartleys@xxxxxxxxxxxxxxxxxxx> wrote:
> Change all the printk()s in mm/slub.c to the pr_*() notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 65ffda5..2805b7f 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -338,25 +338,25 @@ static void print_section(char *text, u8 *addr, unsigned int length)
>
>        for (i = 0; i < length; i++) {
>                if (newline) {
> -                       printk(KERN_ERR "%8s 0x%p: ", text, addr + i);
> +                       pr_err("%8s 0x%p: ", text, addr + i);

Hmm, isn't the whole point of pr_err() that you override pr_fmt() to
include your subsystem name?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/